Fix validation errors when defining multiple query parameters on an operation using the :property template valid + property restriction.
#7461
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Oct 24, 2025
| $parameters = $operation->getParameters() ?? new Parameters(); | ||
| foreach ($parameters as $key => $parameter) { | ||
| ['propertyNames' => $propertyNames, 'properties' => $properties] = $this->getProperties($resourceClass, $parameter); | ||
| ['propertyNames' => $propertyNames, 'properties' => $properties] = $this->getProperties($resourceClass, $parameter, $key); |
There was a problem hiding this comment.
What bother's me is that a parameter should always have akey, would it be possible to change the loop and do:
foreach ($parameters as $key => $parameter) {
if (!$parameter->getKey()) {
$parameter = $parameter->withKey($key);
}
There was a problem hiding this comment.
Can confirm that works! Have updated the PR.
DavidBennettUK
force-pushed
the
multiple-query-parameter-property-placeholders-validation-issue
branch
from
63f9726 to
54bfe18
Compare
DavidBennettUK
force-pushed
the
multiple-query-parameter-property-placeholders-validation-issue
branch
from
54bfe18 to
d1e10c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #7460. This fixes the issue for me, but not sure if it's the best way, or if there will be any side effects.